operator: make templated crds specless #2419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
requested review from
Haleygo,
f41gh7 and
zekker6
as code owners
AndrewChubatiuk
force-pushed
the
crds-chart-divide-into-subcharts
branch
10 times, most recently
from
b92c9a2 to
f0a1d03
Compare
AndrewChubatiuk
force-pushed
the
crds-chart-divide-into-subcharts
branch
2 times, most recently
from
6a474f9 to
9340f3f
Compare
AndrewChubatiuk
force-pushed
the
crds-chart-divide-into-subcharts
branch
2 times, most recently
from
d665107 to
6b9bd73
Compare
AndrewChubatiuk
changed the title
Haleygo
approved these changes
Sep 17, 2025
AndrewChubatiuk
force-pushed
the
crds-chart-divide-into-subcharts
branch
2 times, most recently
from
1579e1b to
385fa6e
Compare
fkajerry
reviewed
Sep 24, 2025
| requests: | ||
| cpu: "100m" | ||
| memory: "56Mi" | ||
| upgrade: |
There was a problem hiding this comment.
This configuration also needs to be synchronized and updated in charts/victoria-metrics-k8s-stack/values.yaml victoria-metrics-operator section.
There was a problem hiding this comment.
it's a two step action, first operator chart should be released, otherwise CI fails
AndrewChubatiuk
force-pushed
the
master
branch
2 times, most recently
from
bed2069 to
4180549
Compare
|
/lgtm |
AndrewChubatiuk
force-pushed
the
crds-chart-divide-into-subcharts
branch
2 times, most recently
from
6bd26ce to
227e5c9
Compare
AndrewChubatiuk
changed the title
AndrewChubatiuk
force-pushed
the
crds-chart-divide-into-subcharts
branch
7 times, most recently
from
fab4eb7 to
88b57fe
Compare
AndrewChubatiuk
changed the title
AndrewChubatiuk
force-pushed
the
crds-chart-divide-into-subcharts
branch
3 times, most recently
from
b1ebcaa to
413535b
Compare
AndrewChubatiuk
changed the title
AndrewChubatiuk
force-pushed
the
crds-chart-divide-into-subcharts
branch
3 times, most recently
from
10de143 to
2f2ae26
Compare
AndrewChubatiuk
force-pushed
the
master
branch
from
23f562a to
1eca8e2
Compare
AndrewChubatiuk
force-pushed
the
crds-chart-divide-into-subcharts
branch
from
2f2ae26 to
80760fd
Compare
Co-authored-by: Hui Wang <[email protected]>
AndrewChubatiuk
force-pushed
the
crds-chart-divide-into-subcharts
branch
from
80760fd to
c4474d7
Compare
AndrewChubatiuk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2420
fixes #2334
.Values.admissionWebhooks.enabledCRDValidationwith.Values.admissionWebhooks.disabledForlist of CRDs for which validation webhook should be disabledcrds.plain: falsespecless.Values.crds.enabledproperty value.Values.crds.plain: true)also related added related PR to operator repo